Skip to content

Conversation

gante
Copy link
Member

@gante gante commented Sep 5, 2025

What does this PR do?

See title :)

Copy link
Contributor

github-actions bot commented Sep 5, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: bloom, codegen, cohere2, dbrx, decision_transformer, falcon, gemma3, git, glm4v, glm4v_moe, gpt_neo, gpt_neox, gpt_neox_japanese, gptj, granitemoe, granitemoeshared

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Always makes me happy to delete deprecated code! 🤗

Comment on lines -580 to -581
elif past_key_values is None:
past_key_values = DynamicCache(config=self.config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we end up with twice the same branch? 😆😆 Thanks for removing!

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, 2 more releases and we'll have no traces of tuple cache left in repo :)

@gante gante merged commit de5cbe8 into huggingface:main Sep 9, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants