Skip to content

Conversation

geoffrey-young
Copy link

@geoffrey-young geoffrey-young commented Sep 6, 2025

What does this PR do?

Fixes issue where num_assistant_tokens and other parameters intended for the assistant model are not properly passed down, leaving the assistant model with default values.

Ultimately, we want to configure the assistant model properly, so that it:

  1. Is properly configured with user-provided parameters
  2. Inherits defaults from the main model instead of class defaults

Tests added to illustrate the issue, and detailed comments to illustrate behaviors.

Fixes # 40739

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

cc @gante

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants