Assume torch in certain files #40742
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyyever
force-pushed
the
assume_torch
branch
4 times, most recently
from
5edf8a7 to
d0a30b9
Compare
Signed-off-by: Yuanyuan Chen <[email protected]>
cyyever
force-pushed
the
assume_torch
branch
from
d0a30b9 to
35c0821
Compare
|
This is definitely something that'll need a core maintainer, since it's part of the transition to being Torch-only. cc @ArthurZucker @Cyrilvallez ! |
Cyrilvallez
reviewed
Sep 8, 2025
There was a problem hiding this comment.
cc @ArthurZucker, there are quite some places where we could start to import without protection I think, but it's not obvious where/when we want to change it
| extras["quality"] = deps_list("datasets", "ruff", "GitPython", "urllib3", "libcst", "rich", "pandas") | ||
| extras["quality"] = deps_list("datasets", "ruff", "GitPython", "urllib3", "libcst", "rich", "pandas", "torch") |
There was a problem hiding this comment.
We don't want to change this
There was a problem hiding this comment.
Without it quality check fails with torch import errors. As we are moving to a more PyTorch centric position, it is acceptable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Always import torch in some source files that are PT only.