Skip to content

Conversation

August-murr
Copy link
Contributor

What does this PR do?

Fixes #40723

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

cc @Cyrilvallez to decide if we still need that warning or not

@Cyrilvallez
Copy link
Member

Indeed, I wanted to remove it before as well, so happy to do it! It's an artifact of the time when the hybrid attention was very fragile due to the masking etc, but it is no longer the case and there is no need for the warning.

It should be removed in modular though, and in other gemmas as well!

Copy link
Contributor

github-actions bot commented Sep 8, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma2, gemma3, gemma3n, t5gemma

Copy link
Member

@Cyrilvallez Cyrilvallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot! Happy to remove!

@Cyrilvallez Cyrilvallez merged commit 9ab6078 into huggingface:main Sep 8, 2025
15 checks passed
@August-murr August-murr deleted the remove_gemma3_warning branch September 8, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gemma3 with flash-attention2 outputs warning
3 participants