Skip to content

Conversation

undertaker86001
Copy link

What does this PR do

Related to issue-456

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@medcl
Copy link
Member

medcl commented Aug 14, 2025

@sowen1023 please help to review this PR

@undertaker86001 undertaker86001 marked this pull request as ready for review August 16, 2025 00:22
- Add missing 'if' keyword in conditional statement at line 257
- Fixes parsing error that prevented tests from running

Co-Authored-By: windWheel <[email protected]>
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing...

count := 0
maxBatchSize := 1000 // Prevent memory overflow

for cursor.Next(context.Background()) && count < maxBatchSize {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use len(documents) instead of count to eliminate the separate variable?

return nil
}

func (p *Plugin) shouldStop() bool {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldStop is never used and should not be used like this.

@medcl
Copy link
Member

medcl commented Aug 25, 2025

@undertaker86001 any updates of this PR?

@undertaker86001
Copy link
Author

@undertaker86001 any updates of this PR?

I'm resolving a conflict.

@@ -17,6 +17,10 @@ export const Types = {
RSS: 'rss',
S3: 's3',
Yuque: 'yuque',
S3: 's3',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated key S3 here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also Confluence and NetworkDrive

@medcl
Copy link
Member

medcl commented Sep 1, 2025

plugins/connectors/mongodb/scanner.go:69:44: collConfig.TitleField undefined (type CollectionConfig has no field or method TitleField)
plugins/connectors/mongodb/scanner.go:69:75: collConfig.ContentField undefined (type CollectionConfig has no field or method ContentField)
plugins/connectors/mongodb/scanner.go:70:14: collConfig.CategoryField undefined (type CollectionConfig has no field or method CategoryField)
plugins/connectors/mongodb/scanner.go:70:48: collConfig.TagsField undefined (type CollectionConfig has no field or method TagsField)
plugins/connectors/mongodb/scanner.go:71:14: collConfig.URLField undefined (type CollectionConfig has no field or method URLField)
plugins/connectors/mongodb/scanner.go:71:43: collConfig.TimestampField undefined (type CollectionConfig has no field or method TimestampField)
plugins/connectors/mongodb/scanner.go:78:17: collConfig.TitleField undefined (type CollectionConfig has no field or method TitleField)
plugins/connectors/mongodb/scanner.go:79:59: collConfig.TitleField undefined (type CollectionConfig has no field or method TitleField)
plugins/connectors/mongodb/scanner.go:81:17: collConfig.ContentField undefined (type CollectionConfig has no field or method ContentField)
plugins/connectors/mongodb/scanner.go:82:59: collConfig.ContentField undefined (type CollectionConfig has no field or method ContentField)
plugins/connectors/mongodb/scanner.go:82:59: too many errors
make: *** [build] Error 1

@medcl
Copy link
Member

medcl commented Sep 1, 2025

I don’t think we need a dedicated sync manager or strategy specifically for MongoDB only. If such functionality is required, it should be built on top of the existing connector task infrastructure, and it is target for long term roadmap. For consistency and maintainability, why not keep it simple and align with how the other connectors work?

@undertaker86001
Copy link
Author

I don’t think we need a dedicated sync manager or strategy specifically for MongoDB only. If such functionality is required, it should be built on top of the existing connector task infrastructure, and it is target for long term roadmap. For consistency and maintainability, why not keep it simple and align with how the other connectors work?

OK, I'll make the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants