feat: feishu connector (#71) #493
Conversation
| "url": "http://coco.rs/connectors/feishu", | ||
| "assets": { | ||
| "icons": { | ||
| "default": "/assets/icons/connector/feishu/icon.png" |
There was a problem hiding this comment.
please also commit the icon files
plugins/connectors/feishu/api.go
Outdated
| // connect handles the OAuth authorization request | ||
| func (h *Plugin) connect(w http.ResponseWriter, req *http.Request, _ httprouter.Params) { | ||
| // Get datasource ID from query parameters | ||
| datasourceID := req.URL.Query().Get("datasource_id") |
There was a problem hiding this comment.
prefer to use utils buildin with framework to get parameters h.GetParameter()
There was a problem hiding this comment.
if it is requred, use MustGetParameter
Build redirect_uri from request context instead of hardcoded config. Supports multi-environment deployments automatically. Add feishu icon.
- Dynamic redirect_uri support for multi-environment deployment - Complete refresh_token expiry handling - Fix OAuth scope issues with Feishu API - Enhanced documentation with permission requirements
shzhzichen
force-pushed
the
feat/feishu-connector
branch
from
ea077d6 to
2ca38e4
Compare
|
@shzhzichen, I've noticed an issue with the icon, The format appears to be incorrect, which is causing them to display improperly. |
|
1、The icon issue has been resolved. The data source connection requires frontend collaboration for development, and the data source needs to be configured with authentication information. For specific parameters, please refer to the README. 2、Since the Feishu and Lark connectors are highly similar, the code structure has been redesigned to be compatible with both Feishu and Lark connectors. |
I think this is the main difference compared with other connectors. May I ask if this design is reasonable and acceptable?
|
|
the google drive use client side oauth to get the access token, and should be similar thing |
|
Okay, I will revise it again according to this structure. |
|
the icon size should |
|
They are all 64x64, so there’s no problem. |
ok, it should be an icon like this:
|
|
ok, all done |
|
@shzhzichen it seems the |
|
@medcl Yes, I will use Postman to test the creation of data sources and the querying of document lists before submitting the PR. |
|
@shzhzichen you can merge the code from |
|
use |
What does this PR do
add feishu connector
Rationale for this change
Standards checklist