Skip to content

Conversation

inosmeet
Copy link
Contributor

inosmeet added 2 commits July 23, 2024 10:09
Signed-off-by: Meet Soni <[email protected]>
Signed-off-by: Meet Soni <[email protected]>
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. I think you're right that we need a network test for coverage purposes, but I feel like we also could use a similar test against the local cache. My brain is fried from vacation: do we already have a similar test against the local cache or should we refactor to make this work locally or against a new network downloaded db?

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it'll work. I love the way you handled the parameterization with the internal/external test difference.

@terriko terriko merged commit 58ba0b7 into intel:main Jul 30, 2024
@inosmeet inosmeet deleted the test-purl2cpe branch August 13, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants