[SYCL] Reuse root device build for sub-sub-devices #20051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current root device ascent logic lead to reuse only for sub-devices, but we want reuse to happen for sub-sub-devices as well, this PR fixes that.
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
|
@intel/unified-runtime-reviewers , any chance that all that logic should just go into the UR instead? I.e., building kernel for a [sub-]*device would automatically build/re-use the kernel built for the root device if possible. |
aelovikov-intel
approved these changes
Sep 10, 2025
Co-authored-by: Andrei Elovikov <[email protected]>
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 18, 2025
Current root device ascent logic lead to reuse only for sub-devices, but we want reuse to happen for sub-sub-devices as well, this PR fixes that.
AlexeySachkov
added a commit
that referenced
this pull request
Sep 18, 2025
This is a cherry-pick of #20051 Current root device ascent logic lead to reuse only for sub-devices, but we want reuse to happen for sub-sub-devices as well, this PR fixes that. Patch-by: Artur Gainullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current root device ascent logic lead to reuse only for sub-devices, but we want reuse to happen for sub-sub-devices as well, this PR fixes that.