Skip to content

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Jul 2, 2025

Thanks to AI, we have just found out the typo.
we have not noticed the typo for 5 years, so far 😂

I noticed this while working on a side project.
kazupon/gunshi@08111f8#diff-dc06d3cebbf88f0f86a5b8eefba8c4a2e349130eec7d1af4b69ecfbe3ffb909cR377

Copy link

coderabbitai bot commented Jul 2, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kazupon kazupon added the Type: Improvement Includes backwards-compatible fixes label Jul 2, 2025
Copy link

cloudflare-workers-and-pages bot commented Jul 2, 2025

Deploying vue-i18n-next with  Cloudflare Pages  Cloudflare Pages

Latest commit: 62b6b1d
Status: ✅  Deploy successful!
Preview URL: https://9d1f55bb.vue-i18n-next.pages.dev
Branch Preview URL: https://fix-core-base-typo.vue-i18n-next.pages.dev

View logs

Copy link

pkg-pr-new bot commented Jul 2, 2025

Open in StackBlitz

@intlify/core

npm i https://pkg.pr.new/@intlify/core@2221

@intlify/core-base

npm i https://pkg.pr.new/@intlify/core-base@2221

@intlify/devtools-types

npm i https://pkg.pr.new/@intlify/devtools-types@2221

@intlify/message-compiler

npm i https://pkg.pr.new/@intlify/message-compiler@2221

petite-vue-i18n

npm i https://pkg.pr.new/petite-vue-i18n@2221

@intlify/shared

npm i https://pkg.pr.new/@intlify/shared@2221

vue-i18n

npm i https://pkg.pr.new/vue-i18n@2221

@intlify/vue-i18n-core

npm i https://pkg.pr.new/@intlify/vue-i18n-core@2221

commit: 62b6b1d

@kazupon kazupon merged commit 80ba5c9 into v11 Jul 2, 2025
44 of 49 checks passed
@kazupon kazupon deleted the fix/core-base-typo branch July 2, 2025 14:59
@kazupon kazupon mentioned this pull request Jul 2, 2025
@maxdzin
Copy link

maxdzin commented Jul 3, 2025

@kazupon It is nice that it was fixed, but it caused this issue:
intlify/h3#50
which suddenly breaks work of other intlify packages.

@hannoeru
Copy link

hannoeru commented Jul 3, 2025

@kazupon This looks like a breaking changes, other package that using core-base will also need to update the imports and limit the version of core-base to ^11.1.8. or we can have a alias for the old consistent to make sure backward compatibility.

I just notice that when I do package update, I got this error:

Uncaught SyntaxError: The requested module '/_nuxt/@fs/Users/hanlee/projects/bx-console/node_modules/.cache/vite/client/deps/@intlify_core-base.js?v=8c3f083d' does not provide an export named 'NOT_REOSLVED' (at vue-i18n.mjs:7:282)

@kazupon
Copy link
Member Author

kazupon commented Jul 3, 2025

Sorry, I overlooked that point.
v11 will be reverted.

kazupon added a commit that referenced this pull request Jul 3, 2025
This reverts commit 80ba5c9.
@kazupon kazupon mentioned this pull request Jul 3, 2025
kazupon added a commit that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Includes backwards-compatible fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants