Skip to content

feat(ui): crop tool #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

feat(ui): crop tool #8562

wants to merge 35 commits into from

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Sep 12, 2025 •
edited
Loading

Summary

  • Add crop tool
  • Enabled only on Video tab

Related Issues / Discussions

n/a

QA Instructions

It's only on the video tab and only partially integrated.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • ❗Changes to a redux slice have a corresponding migration
  • Documentation added / updated (if applicable)
  • Updated What's New copy (if doing a release after this PR)

@github-actions github-actions bot added the frontend PRs that change frontend files label Sep 12, 2025
Mary Hipp and others added 25 commits September 15, 2025 17:22
@psychedelicious
show warning state with tooltip if starting frame image aspect ratio …
6e25146 
…does not match the video output aspect ratio'
@psychedelicious
create editImageModal that takes an imageDTO, loads blob onto canvas,…
a4ff528 
… and allows cropping. cropped blob is uploaded as new asset
@psychedelicious
chore(ui): lint
34972ab
@psychedelicious
tidy(ui): editor cleanup
522fe5a
@psychedelicious
tidy(ui): editor component cleanup
d6fc065
@psychedelicious
feat(ui): tweak editor konva styles
ac05958
@psychedelicious
feat(ui): image editor bg checkerboard pattern
46cb36e
@psychedelicious
tidy(ui): lint/react conventions for editor component
3efa22c
@psychedelicious
feat(ui): type narrowing for editor output types
50c74ae
@psychedelicious
feat(ui): misc iterate on editor
c237cb5
@psychedelicious
tidy(ui): cleanup
197f633
@psychedelicious
feat(ui): crop doesn't hide outside cropped region
3a35237
@psychedelicious
feat(ui): do not clear crop when canceling
01b7c21
@psychedelicious
chore(ui): lint
4b47e2c
@psychedelicious
refactor(ui): editor init
2c3bd33
@psychedelicious
refactor(ui): editor (wip)
cf70967
@psychedelicious
refactor(ui): editor (wip)
86899e9
@psychedelicious
refactor(ui): editor (wip)
dc608c9
@psychedelicious
feat(ui): clean up editor
a73bbe2
@psychedelicious
feat(ui): extract config to own obj
eac0baf
@psychedelicious
refactor(ui): simplify crop constraints
0953914
@psychedelicious
tidy(ui): editor listeners
2e16da8
@psychedelicious
tidy(ui): editor misc
36ba7b0
@psychedelicious
docs(ui): add comments to editor
fe54971
@psychedelicious
feat(ui): add concept for editable image state
e9a79ae
@psychedelicious psychedelicious force-pushed the maryhipp/starting-frame-crop branch from 7d98d66 to e9a79ae Compare September 15, 2025 10:03
@psychedelicious psychedelicious marked this pull request as ready for review September 15, 2025 13:03
@psychedelicious psychedelicious enabled auto-merge (rebase) September 16, 2025 08:24
@psychedelicious psychedelicious force-pushed the maryhipp/starting-frame-crop branch from 4ceeaa2 to c2683b2 Compare September 16, 2025 08:24
@psychedelicious psychedelicious changed the title feat(ui): mini image editor (crop only) feat(ui): crop tool Sep 16, 2025
@psychedelicious psychedelicious force-pushed the maryhipp/starting-frame-crop branch from c2683b2 to 61da33c Compare September 16, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername