-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add new transaction builder #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DaughterOfMars
wants to merge
41
commits into
sdk-bindings
Choose a base branch
from
feat/new-transaction-builder
base: sdk-bindings
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,546
−5,795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thoralf-M
reviewed
Sep 18, 2025
Thoralf-M
reviewed
Sep 18, 2025
Thoralf-M
reviewed
Sep 18, 2025
Thoralf-M
reviewed
Sep 18, 2025
Thoralf-M
reviewed
Sep 18, 2025
What I like about this PR:
What I don't like that much:
|
Thoralf-M
reviewed
Sep 22, 2025
Thoralf-M
reviewed
Sep 22, 2025
Thoralf-M
reviewed
Sep 22, 2025
Thoralf-M
reviewed
Sep 22, 2025
Thoralf-M
reviewed
Sep 22, 2025
Thoralf-M
reviewed
Sep 23, 2025
Thoralf-M
reviewed
Sep 23, 2025
Thoralf-M
reviewed
Sep 23, 2025
Thoralf-M
reviewed
Sep 23, 2025
Thoralf-M
reviewed
Sep 23, 2025
Thoralf-M
reviewed
Sep 23, 2025
Thoralf-M
reviewed
Sep 24, 2025
Thoralf-M
reviewed
Sep 25, 2025
Thoralf-M
reviewed
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an entirely new transaction builder based on experimental changes originally made on the core repository. Fundamentally, this allows a much simpler API in Rust, while also somewhat simplifying the bindings API.
Features
&str
instead ofIdentStr
orIdentifier
.MoveParams
can be used for move call params. Tuples up to length 6 are implemented. Longer param lists can be achieved using nested tuples.CustomMoveType
(with helper macromove_type!
)TypeTag
s (viaMoveType
trait).Res
.MoveParam
trait).