Allow pinning unresolved comments or creating a "needs to be resolved" item

[johnsenpeder]

When there are a certain number of commits/comments on a PR, a lot of them will end up hidden.
There are cases where you create a PR but some of the code will have to be changed for when the PR can be merged and code put live (hard coded release dates that needs to be references in code to prevent or to specifically run certain code etc)

If you add a comment referencing the code that needs to be changed, this comment could potentially end up hidden and get missed.

Some way to either pin unresolved comments to prevent them being hidden, or a way for PR authors to add "needs to be resolved" items/comments would be a nice addition that would prevent these scenarios.

[I've emailed GitHub with this feedback and awaiting a reply, will update with their response if/when I get one]

[johnsenpeder]

Github reply so far:

Thanks for writing in about this.

We'll pass this along to our design team. I can't promise if or when this might be addressed but your feedback is in good hands!

[cirosantilli]

Related: #1008

[0xdevalias]

While it's not a direct 'on platform' solution, I came up with the following script to pull this info from the GitHub v4 GraphQL API:

• https://stackoverflow.com/questions/55713929/list-all-unresolved-pull-request-comments/66072198#66072198

# Usage:
#   Retrieve unresolved review comments
#     ./pr-unresolved-review-comments myorganisation myrepo 1337
#
#   Count of unresolved review comment threads
#     ./pr-unresolved-review-comments myorganisation myrepo 1337 | jq length

OWNER=$1
REPO=$2
PR=$3

gh api graphql -f query="
  query FetchReviewComments {
    repository(owner: \"$OWNER\", name: \"$REPO\") {
      pullRequest(number: $PR) {
        url
        reviewDecision
        reviewThreads(first: 100) {
          edges {
            node {
              isResolved
              isOutdated
              isCollapsed
              comments(first: 100) {
                totalCount
                nodes {
                  author {
                    login
                  }
                  body
                  url
                }
              }
            }
          }
        }
      }
    }
  }
" | jq '.data.repository.pullRequest.reviewThreads.edges | map(select(.node.isResolved == false))'

Which has output like:

[
  {
    "node": {
      "isResolved": false,
      "isOutdated": true,
      "isCollapsed": false,
      "comments": {
        "totalCount": 7,
        "nodes": [
          {
            "author": {
              "login": "0xdevalias"
            },
            "body": "This is an unresolved comment that is important!",
            "url": "https://github.com/myorganisation/myrepo/pull/1337#discussion_r559294516"
          },
          ..snip..
        ]
      }
    }
  },
  ..snip..
]