Skip to content

Conversation

benfrankel
Copy link
Contributor

@benfrankel benfrankel commented May 19, 2025

Notes:

  • A version with Bevy 0.15 support was never published, so a release on this PR would jump straight from 0.14 to 0.16.
  • bevy_egui has some new guidelines for library authors. In the interest of making this PR as self-contained as possible, I didn't update bevy_editor_pls to satisfy these guidelines.
  • I made the straightforward translation from single() -> single().unwrap() and get_single() -> single() instead of trying to remove the panics.
  • The new recommended naming convention for system sets is FooSystems, but I didn't make the change in this PR.
  • The new Projection component means that queries can no longer fragment on the type of projection an entity uses, so now those entities will instead be skipped by a guard let-else if they don't use orthographic projection.

Testing:

  • cargo run --example breakout compiled and ran, and pressing E toggled the editor UI.
  • Seems to work in my personal game template.

@benfrankel benfrankel marked this pull request as ready for review May 19, 2025 23:52
@HugoPeters1024
Copy link

Tried it out on a project using bevy 0.16.1, works as advertised!

@martinfrances107
Copy link

  1. As a field report

I can confirm that after migrating my app to bevy 0.16, using this PR as a patch restores bevy_editor_pls functionality.

[patch.crates-io]
bevy_editor_pls = { git = "https://github.com/benfrankel/bevy_editor_pls/", branch = "bevy-0-16" }

No crashes, no loss of functionality

  1. I have also looked over this PR visually, it introduces calls ot unwrap() .. most of which I can justify in their context

The ones I have trouble with are a minor... and I think are best handling in followup PRs.

In short + 1 from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants