Encoder soundness fix #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utside of a private module
|
It seems I forgot to update some tests. That's odd, I could have sworn I ran |
|
Oh, tests were added after this PR. That makes sense. Anyway, fixed now. |
|
One of the tests was supplying an input buffer that was too short. I've fixed that. |
jaredforth
approved these changes
Aug 27, 2025
|
Thank you! Could you publish a new release to crates.io as well, so that I could stop relying on git versions in my projects? Having git dependencies makes code difficult to distribute. |
Yep! I'll get a release cut today or tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
This is a semver-compatible change so that the fix can be easily adopted by any users of this crate.