Update flatten helper without recursion #5454
Conversation
Connormiha
force-pushed
the
optimize-flatten-helper
branch
from
3d7349d to
45c9449
Compare
Connormiha
force-pushed
the
optimize-flatten-helper
branch
from
45c9449 to
fbb3518
Compare
src/helpers.coffee
Outdated
| if '[object Array]' is Object::toString.call element | ||
| stack.push(element) | ||
| else | ||
| flattened.push(element) |
There was a problem hiding this comment.
Perhaps instead we should use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/flat? I don’t think we even need to feature-detect it, support goes very far back.
There was a problem hiding this comment.
Yes, we can use this if old browser/Node.js support is not required.
exports.flatten = flatten = (array) ->
array.flat(10)10 - is max depth
There was a problem hiding this comment.
Yes, we can use this if old browser/Node.js support is not required.
You can look in our GitHub Actions to see our support matrix, but basically everywhere we support can run .flat. You can use .flat(Infinity) to go as far down as necessary.
There was a problem hiding this comment.
I changed it and built.
npx cake build
npx cake build:browserThere was a problem hiding this comment.
CI is failing. Try cake release?
I've rewritten the
flattenalgorithm. Instead of a recursive approach, i'm using a stack. This way, we avoid unnecessary function calls and the creation of intermediate arrays.flattenedin each call and new array after eachconcat.In cases of deep recursion or with a large number of arrays, this algorithm is more efficient and generates less work for the garbage collector.