Skip to content

Conversation

bertonha
Copy link
Contributor

the sub dependency of apns2 hyper is completely abandoned and it does not support python 3.10
simple because it uses some packages from collections where on python 3.10 it moved to collections.abc

I think the clean way to properly fix it, would be to move to a more maintained package to do Apple Push Notifications.
which might be aioapns

@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #648 (7cb6936) into master (db0606c) will increase coverage by 0.07%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #648      +/-   ##
==========================================
+ Coverage   68.43%   68.51%   +0.07%     
==========================================
  Files          26       26              
  Lines        1112     1121       +9     
  Branches      243      244       +1     
==========================================
+ Hits          761      768       +7     
- Misses        313      315       +2     
  Partials       38       38              
Impacted Files Coverage Δ
push_notifications/__init__.py 85.71% <77.77%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db0606c...7cb6936. Read the comment docs.

@Andrew-Chen-Wang
Copy link
Member

Andrew-Chen-Wang commented Jan 25, 2022

apns2 is a pain since no one maintains this valuable package. We should get everyone to use a fork instead. aioapns is for asyncio.

We can name the fork apns2-py and set it up in Jazzband for maintenance.

@azmeuk azmeuk mentioned this pull request Aug 3, 2023
@bertonha bertonha closed this by deleting the head repository Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants