Fix TypeError in RedisCache.close() when called with signal parameter #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove **kwargs from self.client.close() call in RedisCache.close() - The DefaultClient.close() method doesn't accept parameters since commit c7be6cc - This fixes TypeError when Django's request_finished signal calls cache.close(signal=...) - Add test case to verify close() works with arbitrary keyword arguments Fixes issue where django-redis 6.0+ would crash with: TypeError: close() got an unexpected keyword argument 'signal'
for more information, see https://pre-commit.ci
|
@smaccona Django 6 is not out yet, can you add it first and then fix the error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where django-redis 6.0+ would crash with: TypeError: close() got an unexpected keyword argument 'signal'
Closes #787.