Skip to content

Conversation

gabang2
Copy link

@gabang2 gabang2 commented Aug 31, 2025

The documentation for enabling the hiredis parser is outdated. It currently instructs users to set the PARSER_CLASS option, which is no longer the recommended or necessary approach.

redis-py automatically detects and uses the high-performance hiredis parser if the package is installed in the environment. No additional configuration is required from the user.

This PR updates the "Pluggable parsers" section in README.rst to align with the current behavior by:

  • Removing the obsolete PARSER_CLASS configuration example.
  • Clarifying that hiredis is used automatically by default when installed.
  • Providing the simple pip install hiredis command as the only required step.

This change makes the documentation more accurate and user-friendly, ensuring that users can easily leverage the performance benefits of hiredis without confusion.

Depends on :

@WisdomPill
Copy link
Member

I will take some time to verify if we need to remove the default parser, cause if redis already does the parsing we might need to not redo it

Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.5%. Comparing base (9423cee) to head (2c0dad6).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #791   +/-   ##
======================================
  Coverage    38.5%   38.5%           
======================================
  Files          44      44           
  Lines        3320    3320           
  Branches      245     245           
======================================
  Hits         1276    1276           
  Misses       1799    1799           
  Partials      245     245           
Flag Coverage Δ
mypy 38.5% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants