Skip to content

Add setting for expiry format, add helper methods in login view #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 1, 2019
Merged

Add setting for expiry format, add helper methods in login view #180

merged 6 commits into from
Jun 1, 2019

Conversation

loicgasser
Copy link
Contributor

Replaces #179
Fixes #171
Fixes #178

  • Now expiry format defaults to whatever is used Django REST framework
  • This behavior can be overriden via EXPIRY_DATETIME_FORMAT setting
  • fully customizable expiry format via format_expiry_datetime
  • fully customizable response payload via get_post_response_data

johnraz
johnraz approved these changes May 24, 2019
View reviewed changes
Copy link
Collaborator

@johnraz johnraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! PR looks good to me as is. Huge thanks for your patience and time 👍🏻

@loicgasser
Copy link
Contributor Author

Thanks, no problem. It was a pleasure.

@loicgasser
Copy link
Contributor Author

@belugame any chance to have a second pair of eyes on this and maybe a version bump?

@belugame belugame changed the base branch from master to develop June 1, 2019 06:19
@belugame belugame merged commit 4e87188 into jazzband:develop Jun 1, 2019
belugame
belugame reviewed Jun 1, 2019
View reviewed changes
Copy link
Collaborator

@belugame belugame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loicgasser Thank you very much for your high quality work! Just released it as 4.1.0 :)

docs/settings.md
or a Python [strftime format][strftime format] string.

[DATETIME_FORMAT]: https://www.django-rest-framework.org/api-guide/settings/#date-and-time-formatting
[strftime format]: https://docs.python.org/3/library/time.html#time.strftime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nice!

@johnraz johnraz mentioned this pull request Jun 30, 2019
Closed
dontexit pushed a commit to dontexit/django-rest-knox that referenced this pull request Jan 24, 2024
@belugame
Merge pull request jazzband#180 from loicgasser/issue_178_bis
3107b57 
Add setting for expiry format, add helper methods in login view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belugame belugame belugame left review comments

@johnraz johnraz johnraz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loicgasser @johnraz @belugame