This project looks py3k compliant. Your setup.py don't say it is.

[Christophe31]

I'm asking my-self if I make one of my projects python 3.4/django 1.7 as I have big refactoring in front of me.

I used the nice tool https://caniusepython3.com/ and it told me that django-sendfile is not py3k compliant. When I read my self, it looks already compliant or trivial to port.

You probably should update your setup.py except if you haven't tried your project on py3k yet.

If you ran your tests against python 3, you probably should add this to your classifiers:

classifiers = [
"Programming Language :: Python :: 2",
"Programming Language :: Python :: 3",]

[NotSqrt]

👍

[johnsensible]

Must admit I'm still in Python 2 land at the moment. I'm using Python 3 for a small (non-django) project at home, but that's about it.

So I've not been looking to port any code to 3 yet and hence not 100% sure what needs doing and even how I've support 2 + 3 at the same time...

[NotSqrt]

Supporting python 2 and 3 with the same code base is indeed possible.

One of the best ressources for porting : http://lucumr.pocoo.org/2013/5/21/porting-to-python-3-redux/

[NotSqrt]

And for django-specific things : https://docs.djangoproject.com/en/1.7/topics/python3/

[Christophe31]

I even think you don't necesarily need code change from what I read fromthe project.

[johnsensible]

@NotSqrt hmmm. Whilst it seems possible, that seems like a lot to take in/deal with.

Pretty time constrained at the moment (busy at work + young son + new baby), so this is hardly a priority for me (given I'm not using Python 3). I probably need either a pull request or someone to explain in very simple terms what actually needs to happen here.

[Christophe31]

It's a long ago now, I'm not sure if I tested, but I think I tryed it with a python 3 project. The only thing was it didn't officially supported python 3 but it worked in my use-case. (Even thaugt, as I had tons of other dependencies, I choosed py2 at last).

For me you should just add the classifier and wait for bug repports ;-)

[NotSqrt]

I will add tox so that we can test more easily that everything is indeed all right.

[Christophe31]

it sounds far more reasonable than my suggestion.

[NotSqrt]

😄

[timabbott]

Yeah, it'd be great to have this tagged as supporting Python 3. We're looking at using this project in Zulip and we're close to moving to full Python 3 support. We'll likely report bugs if it doesn't work :)