Add a setting for the fields visibility #14
Conversation
… from page config
| // If the secret fields are hidden from constructor, this setting comes from | ||
| // PageConfig, we need to lock the fields visibility. | ||
| if (options.showSecretFields === false) { | ||
| Private.lockFieldsVisibility(); | ||
| } |
There was a problem hiding this comment.
Lock the visibility setting if it is explicitly false at startup (coming from page config)
| export function setSecretFieldsVisibility(value: boolean): boolean { | ||
| if (!fieldsVisibilityLocked && value !== secretFieldsVisibility) { | ||
| secretFieldsVisibility = value; | ||
| return true; | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Do not update the visibility if locked.
| if (PageConfig.getOption('secretsManager-showFields') === 'false') { | ||
| showSecretFieldsConfig = false; | ||
| } | ||
|
|
||
| const manager = new SecretsManager({ | ||
| showSecretFields: showSecretFieldsConfig | ||
| }); |
There was a problem hiding this comment.
Read the page config and setup the fields visibility at instantiation if required, to lock the setting.
| if (!showSecretFieldsConfig) { | ||
| delete settings.schema.properties?.['ShowSecretFields']; | ||
| return; | ||
| } |
There was a problem hiding this comment.
Remove the visibility setting from the schema if it locked.
|
cc. @afshin, I don't know why I can't add you to the reviewers from UI... |
|
|
||
| // Otherwise listen to it to update the field visibility. | ||
| const updateFieldVisibility = () => { | ||
| const showSecretField = |
There was a problem hiding this comment.
| const showSecretField = | |
| if(!showSecretFieldsConfig ){ | |
| return; | |
| } | |
| const showSecretField = |
There was a problem hiding this comment.
Do you think this is necessary ?
This function shouldn't be called because of the return statement just above(on the same condition), and even if it is, that should not change anything because the settings is locked in the manager.
|
Thanks for the review |
This PR adds a setting for the field visibility, and a signal when this setting changes.
Updating this setting doesn't change anything in UI from the secrets manager itself.
Only the extensions that uses the secrets manager (and listen for this setting) can display or not some fields.
If the settings are hidden from page config, this setting is removed from the settings panel and cannot be updated (the value is locked). This should prevent third party extensions to modify the value to display the fields (and be able to read the values from the DOM).