Pass on theme change to cockle #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR identifies when there is a theme change in JupyterLite and passes that information on to
cockleso that it can modify the prompt color, etc, in response. There are two possible sources of theme change, the first is the terminal theme and the second is the app theme, which only causes a change in the terminal if the terminal theme is set to'inherit'.Uses
cockle 0.1.3as that is the first release to supportIShell.themeChange.Upon the next
cocklerelease we will also be able to pass the optionalisDarkModeboolean flag inLiteTerminalAPIClient.themeChangethat was introduced in jupyterlite/cockle#232.Have updated the
typescriptversion as otherwise see a compilation error inlib0.cockledoes not do much with this information yet, only changing the color of the prompt and of shell error messages. But once the framework is in place for this, it will be simple to expand in future.