Skip to content

chore(eslint): enforce no console logs in codebase #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2025
Merged

chore(eslint): enforce no console logs in codebase #912

merged 1 commit into from
Feb 20, 2025

Conversation

PritishBudhiraja
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Restrict to push the logs

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 20, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  .eslintrc.json  67% smaller
  src/PaymentMethodCollectElement.res Unsupported file format
  src/Payments/BecsBankDebit.res Unsupported file format
  src/Payments/PazeWallet.res Unsupported file format
  src/Payments/QRCodeDisplay.res Unsupported file format
  src/Types/ClickToPayHelpers.res Unsupported file format
  src/Utilities/ApplePayHelpers.res Unsupported file format
  src/Utilities/PaymentHelpers.res Unsupported file format
  src/Utilities/Utils.res Unsupported file format
  src/hyper-loader/Elements.res Unsupported file format
  src/hyper-loader/Hyper.res Unsupported file format
  src/hyper-loader/LoaderPaymentElement.res Unsupported file format
  src/hyper-log-catcher/Sentry.res Unsupported file format

@PritishBudhiraja PritishBudhiraja self-assigned this Feb 20, 2025
@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Feb 20, 2025
@PritishBudhiraja PritishBudhiraja merged commit d83648e into main Feb 20, 2025
3 of 4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the console-warn branch February 20, 2025 13:25
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakksham7 sakksham7 sakksham7 approved these changes

@aritro2002 aritro2002 aritro2002 approved these changes

@Sanskar2001 Sanskar2001 Awaiting requested review from Sanskar2001 Sanskar2001 is a code owner

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@PritishBudhiraja PritishBudhiraja

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PritishBudhiraja @sakksham7 @aritro2002