Skip to content

fix: fixed crypto pay body payload #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

fix: fixed crypto pay body payload #919

merged 1 commit into from
Feb 25, 2025

Conversation

sakksham7
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added field inside payment_method_data for crypto body.

Previous payload for confirm call in case of no required fields :-

payment_method_data : {}

New payload for confirm call in case of no required fields :-

payment_method_data : { crypto: {} }

How did you test it?

Tested cases:-

  • When no required fields are there
  • When required fields are there

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 added Ready for Review PR with label Ready for Review should only be reviewed. Easy Effort: Should be easy to implement and would make a good first PR hyperswitch-web This issue relates to hyperswitch-web SDK. rescript This issue requires a solution implemented using ReScript. labels Feb 25, 2025
@sakksham7 sakksham7 self-assigned this Feb 25, 2025
@sakksham7 sakksham7 requested a review from seekshiva as a code owner February 25, 2025 10:45
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

PritishBudhiraja
PritishBudhiraja approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :')

@PritishBudhiraja PritishBudhiraja merged commit e956628 into main Feb 25, 2025
3 of 4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the crypto-body branch February 25, 2025 10:47
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. Easy Effort: Should be easy to implement and would make a good first PR hyperswitch-web This issue relates to hyperswitch-web SDK. rescript This issue requires a solution implemented using ReScript. labels Feb 25, 2025
PritishBudhiraja pushed a commit that referenced this pull request Feb 27, 2025
@semantic-release-bot
chore(release): 0.115.1 [skip ci]
a3c5c59 
## [0.115.1](v0.115.0...v0.115.1) (2025-02-25)

### Bug Fixes

* fixed crypto pay body payload ([#919](#919)) ([e956628](e956628))
* fixed error handling of click to pay ([#923](#923)) ([2ea9ff1](2ea9ff1))
PritishBudhiraja pushed a commit that referenced this pull request Feb 27, 2025
@semantic-release-bot
chore(release): 0.115.1 [skip ci]
589fcba 
## [0.115.1](v0.115.0...v0.115.1) (2025-02-27)

### Bug Fixes

* fixed crypto pay body payload ([#919](#919)) ([e956628](e956628))
* fixed error handling of click to pay ([#923](#923)) ([2ea9ff1](2ea9ff1))
* Fixed Responsive Behaviour for Saved Cards ([#922](#922)) ([a23fd2b](a23fd2b))
PritishBudhiraja pushed a commit that referenced this pull request Feb 27, 2025
@semantic-release-bot
chore(release): 0.115.1 [skip ci]
2a453fa 
## [0.115.1](v0.115.0...v0.115.1) (2025-02-27)

### Bug Fixes

* fixed crypto pay body payload ([#919](#919)) ([e956628](e956628))
* fixed error handling of click to pay ([#923](#923)) ([2ea9ff1](2ea9ff1))
* Fixed Responsive Behaviour for Saved Cards ([#922](#922)) ([a23fd2b](a23fd2b))
aritro2002 pushed a commit that referenced this pull request Feb 27, 2025
@semantic-release-bot
chore(release): 0.115.1 [skip ci]
ea0fa81 
## [0.115.1](v0.115.0...v0.115.1) (2025-02-27)

### Bug Fixes

* fixed crypto pay body payload ([#919](#919)) ([e956628](e956628))
* fixed error handling of click to pay ([#923](#923)) ([2ea9ff1](2ea9ff1))
* Fixed Responsive Behaviour for Saved Cards ([#922](#922)) ([a23fd2b](a23fd2b))
tekorakle pushed a commit to tekorakle/hyperswitch-web that referenced this pull request Mar 2, 2025
@semantic-release-bot
chore(release): 0.115.1 [skip ci]
27cf544 
## [0.115.1](juspay/hyperswitch-web@v0.115.0...v0.115.1) (2025-02-27)

### Bug Fixes

* fixed crypto pay body payload ([juspay#919](juspay#919)) ([e956628](juspay@e956628))
* fixed error handling of click to pay ([juspay#923](juspay#923)) ([2ea9ff1](juspay@2ea9ff1))
* Fixed Responsive Behaviour for Saved Cards ([juspay#922](juspay#922)) ([a23fd2b](juspay@a23fd2b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aritro2002 aritro2002 aritro2002 approved these changes

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

+1 more reviewer

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sakksham7 sakksham7

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sakksham7 @PritishBudhiraja @aritro2002