feat(metrics): add support for gauge metrics and include IMC metrics #4939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
C-feature
…erswitch into add-support-for-guage-metrics
Comment on lines
11
to
17
| crate::gauge_metrics_for_imc!( | ||
| CONFIG_CACHE, | ||
| ACCOUNTS_CACHE, | ||
| ROUTING_CACHE, | ||
| CGRAPH_CACHE, | ||
| PM_FILTERS_CGRAPH_CACHE | ||
| ); |
There was a problem hiding this comment.
We'd have to include DECISION_MANAGER_CACHE and SURCHARGE_CACHE once #4814 is merged. How can we ensure that developers introducing new cache instances add metrics for them here: would including a comment in crates/storage_impl/src/redis/cache.rs be useful, or is there anything else that can be done?
SanchithHegde
previously approved these changes
Jun 11, 2024
SanchithHegde
approved these changes
Jun 11, 2024
dracarys18
approved these changes
Jun 11, 2024
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds support for gauge metrics. Additionally the pr also adds a background thread, which will be spawned during application startup, that runs for every fixed interval (configurable) of time, collecting the metrics. For now this collector collects the gauge metrics of
cache_entry_countof all the cache types.Additional Changes
Motivation and Context
How did you test it?
Hit list payment methods for a merchant endpoint and check for
router_CACHE_ENTRY_COUNTmetric in grafanaChecklist
cargo +nightly fmt --allcargo clippy