-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(connector): [Xendit] ADD Cards & Mandates Flow #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Xendit] ADD Cards & Mandates Flow #6966
Conversation
6da83bc
to
0fddb93
Compare
crates/router/src/configs/defaults/payment_connector_required_fields.rs
Outdated
Show resolved
Hide resolved
crates/router/src/configs/defaults/payment_connector_required_fields.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/xendit/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/xendit/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/xendit/transformers.rs
Outdated
Show resolved
Hide resolved
crates/hyperswitch_connectors/src/connectors/xendit/transformers.rs
Outdated
Show resolved
Hide resolved
7d6b3a9
to
55e01c1
Compare
crates/hyperswitch_connectors/src/connectors/xendit/transformers.rs
Outdated
Show resolved
Hide resolved
1c9a909
to
282cf08
Compare
customer_acceptance: null, | ||
setup_future_usage: "on_session", | ||
amount: 6500000, | ||
billing: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make billing address as const and use it everywhere ?
}, | ||
currency: "IDR", | ||
mandate_data: null, | ||
customer_acceptance: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also make customer_acceptance as const and use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check this ?
aec75ce
06210f7
to
aec75ce
Compare
aec75ce
to
dce0ac6
Compare
0d814be
to
fc571f4
Compare
billing: billing_details, | ||
}, | ||
setup_future_usage: "off_session", | ||
customer_acceptance: customer_acceptance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you make every variable camelCase just so that we follow a single convention rather than having a mixture of different conventions?
status: 501, | ||
body: { | ||
error: { | ||
type: "invalid_request", | ||
message: "Cancel/Void flow is not supported", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
501
is not implemented error, right? or, is this expected to be a 4xx?
if this is being thrown from backend, then, i feel, it is wrong, we're supposed to throw a 4xx if not supported.
correct me if wrong.
VoidAfterConfirm: { | ||
Request: {}, | ||
Response: { | ||
status: 501, | ||
status: 400, | ||
body: { | ||
error: { | ||
type: "invalid_request", | ||
message: "Cancel/Void flow is not supported", | ||
code: "IR_00", | ||
code: "IR_19", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please verify this once.
e81c6e4
to
6a0291e
Compare
VoidAfterConfirm: { | ||
Request: {}, | ||
Response: { | ||
status: 400, | ||
body: { | ||
error: { | ||
type: "invalid_request", | ||
message: "Cancel/Void flow is not supported", | ||
code: "IR_19", | ||
}, | ||
}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@likhinbopanna, we should take this up in the coming days and put this under getCustomExchange
Type of Change
Description
Added Xendit Cards & Mandates Flow
Additional Changes
Motivation and Context
How did you test it?
**Three-DS **
Redirection Response


Mandates 3DS
MIT-Payments
Sync:
Checklist
cargo +nightly fmt --all
cargo clippy