-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(business_profile): add business_profile config to enable external vault #7876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed Files
|
@@ -0,0 +1,6 @@ | |||
-- Your SQL goes here | |||
ALTER TABLE business_profile | |||
ADD COLUMN IF NOT EXISTS is_external_vault_enabled BOOLEAN DEFAULT FALSE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead adding in default, handle this in code itself, basically null is false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the subsequent PR #7917 where this field is being used, the logic have been added to handle null cases as well👍
pub fn get_is_external_vault_enabled(&self) -> bool {
self.is_external_vault_enabled.unwrap_or(false)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
…adyen-ideal * 'main' of github.com:juspay/hyperswitch: (62 commits) fix(core): language consumption from locale in payment and payout links (#7993) feat(refunds_v2): Add refunds list flow in v2 apis (#7966) refactor(connector): [Noon] auth header (#7977) fix(connector): [Novalnet] send decoded token for apple pay payment (#7973) feat(business_profile): add business_profile config to enable external vault (#7876) feat(vsaas): integrate onboarding flow for vertical saas (#7884) feat(connector): Introduce connector template code for WorldpayXML (#7968) feat(connector): [ADYEN, CHECKOUT] Added In Feature Matrix API (#7914) feat(core): add psync support for recovery external payments (#7855) refactor(open_router): call elimination routing of open router if enabled instead of dynamo (#7961) feat(payment_methods): add v2 api for fetching token data (#7629) ci(cypress): Fix Bank Redirects for stripe test (#8004) chore(version): 2025.05.12.0 refactor(authentication): moved cavv storing from table to temp locker (#7978) chore(version): 2025.05.09.0 feat(connector): [paypal, trustpay] add in feature matrix (#7911) fix(update_metadata): Update Metadata for any connectors other than stripe gives 500 error (#7984) fix(router): Fixed stack over flow for session call in authentication connectors (#7983) chore(version): 2025.05.08.0 fix(payment): disable payment update via client config (#7970) ...
Type of Change
Description
is_externa_vault_enabled
,external_vault_connector_details
is_external_vault_enabled
is a boolean value that decide if external vault is enabled for the given profileexternal_vault_connector_details
collects the vault_connector_id for the external vault where the data will be savedAdditional Changes
add a new field in request of /v2/profiles i.e vault_connector_details which is an nullable object that takes 3 fields
Motivation and Context
How did you test it?
Tested through postman:
Checklist
cargo +nightly fmt --all
cargo clippy