Skip to content

feat(connector): add barclaycard template code #8017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 20, 2025
Merged

feat(connector): add barclaycard template code #8017

merged 7 commits into from
May 20, 2025

Conversation

Anurag-05-prog
Copy link
Contributor

@Anurag-05-prog Anurag-05-prog commented May 13, 2025 •
edited by deepanshu-iiitu
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Closes this issue

Description

added barclaycard template code

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Added template code for barclaycard
Docs Link: https://developer.smartpayfuse.barclaycard/api-reference-assets/index.html

How did you test it?

Only template PR hence no testing required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Anurag-05-prog Anurag-05-prog self-assigned this May 13, 2025
@Anurag-05-prog Anurag-05-prog requested review from a team as code owners May 13, 2025 11:10
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented May 13, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/hyperswitch_connectors/src/connectors.rs  96% smaller
  crates/router/src/connector.rs  90% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  10% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  9% smaller
  config/config.example.toml Unsupported file format
  config/deployments/integration_test.toml Unsupported file format
  config/deployments/production.toml Unsupported file format
  config/deployments/sandbox.toml Unsupported file format
  config/development.toml Unsupported file format
  config/docker_compose.toml Unsupported file format
  crates/common_enums/src/connector_enums.rs  0% smaller
  crates/connector_configs/src/connector.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/barclaycard.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/barclaycard/transformers.rs  0% smaller
  crates/hyperswitch_domain_models/src/configs.rs  0% smaller
  crates/router/src/core/admin.rs  0% smaller
  crates/router/src/types/api.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller
  crates/router/tests/connectors/barclaycard.rs  0% smaller
  crates/router/tests/connectors/main.rs  0% smaller
  crates/router/tests/connectors/sample_auth.toml Unsupported file format
  crates/test_utils/src/connector_auth.rs  0% smaller
  loadtest/config/development.toml Unsupported file format
  scripts/add_connector.sh Unsupported file format

@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels May 13, 2025
@Anurag-05-prog Anurag-05-prog linked an issue May 13, 2025 that may be closed by this pull request
[FEATURE] Barclaycard: Add template PR #8015
Closed
2 tasks
jarnura
jarnura previously approved these changes May 13, 2025
View reviewed changes
@Anurag-05-prog Anurag-05-prog dismissed stale reviews from jarnura and deepanshu-iiitu via 0bb0393 May 15, 2025 07:06
jarnura
jarnura previously approved these changes May 15, 2025
View reviewed changes
@Anurag-05-prog Anurag-05-prog dismissed stale reviews from jarnura and deepanshu-iiitu via a20f61f May 16, 2025 01:40
@hyperswitch-bot hyperswitch-bot bot requested a review from a team as a code owner May 16, 2025 01:41
pixincreate
pixincreate previously approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@pixincreate pixincreate left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cypress, looks good.

cypress-tests/cypress/support/commands.js Outdated
@@ -2876,10 +2888,10 @@ Cypress.Commands.add(
allowedActiveStatuses
);

expect(
response.body.payment_method_status,
expect(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you run link check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

jarnura
jarnura previously approved these changes May 16, 2025
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue May 20, 2025
Merged via the queue into main with commit 6e08edc May 20, 2025
14 of 20 checks passed
@likhinbopanna likhinbopanna deleted the barclays-template branch May 20, 2025 12:15
pixincreate added a commit that referenced this pull request May 20, 2025
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into connector/n…
f1dd0a8 
…ordea-template

* 'main' of github.com:juspay/hyperswitch:
  feat(reveue_recovery): Add support for multiple retry algorithms in revenue recovery workflow (#7915)
  feat(connector): add barclaycard template code (#8017)
  fix(router): fix Click to Pay cavv None error (#8019)
  fix(connector): Supported capture methods fix for feature matrix (#8057)
iemyashasvi pushed a commit that referenced this pull request May 22, 2025
@Anurag-05-prog @hyperswitch-bot @deepanshu-iiitu
feat(connector): add barclaycard template code (#8017)
38aa490 
Co-authored-by: Anurag Singh <[email protected]>
Co-authored-by: Anurag Singh <[email protected]>
Co-authored-by: hyperswitch-bot[bot] <148525504+hyperswitch-bot[bot]@users.noreply.github.com>
Co-authored-by: DEEPANSHU BANSAL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

@pixincreate pixincreate pixincreate approved these changes

Assignees

@Anurag-05-prog Anurag-05-prog

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Barclaycard: Add template PR
5 participants
@Anurag-05-prog @jarnura @deepanshu-iiitu @pixincreate @likhinbopanna