Skip to content

deps(common_utils): put the async ext trait behind a feature #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2023
Merged

deps(common_utils): put the async ext trait behind a feature #835

merged 3 commits into from
Apr 6, 2023

Conversation

vspecky
Copy link
Contributor

@vspecky vspecky commented Apr 4, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

This PR puts the AsyncExt trait and certain async functions in the common_utils crate behind a feature flag.

Additional Changes

None

  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Required to make the api_models crate free of any async-relate dependencies.

How did you test it?

cargo build + cargo hack

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@vspecky vspecky requested review from a team and ashokkjag as code owners April 4, 2023 07:31
@vspecky vspecky self-assigned this Apr 4, 2023
@vspecky vspecky added A-dependencies Area: Dependencies S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Apr 4, 2023
NishantJoshi00
NishantJoshi00 reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@NishantJoshi00 NishantJoshi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that looks good !

@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-ready-for-merge labels Apr 5, 2023
@jarnura jarnura added this pull request to the merge queue Apr 6, 2023
Merged via the queue into main with commit de29eb6 Apr 6, 2023
@SanchithHegde SanchithHegde deleted the async-ext-feature branch April 6, 2023 13:27
@Gnanasundari24 Gnanasundari24 mentioned this pull request Apr 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde Awaiting requested review from SanchithHegde

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

+1 more reviewer

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vspecky vspecky

Labels
A-dependencies Area: Dependencies C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vspecky @jarnura @NishantJoshi00