-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(connector): Add support for get plan prices for Chargebee #9300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,4 @@ | |||
#[derive(Debug, Clone)] | |||
pub struct GetSubscriptionPlanPricesRequest { | |||
pub item_id: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub item_id: String, | |
pub plan_price_id: String, |
connectors: &Connectors, | ||
) -> CustomResult<String, errors::ConnectorError> { | ||
let query_params = get_chargebee_plan_prices_query_params(req)?; | ||
let metadata: chargebee::ChargebeeMetadata = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add corresponding changes for ChargebeeMetadata object in crates/router/src/core/connector_validation.rs
GetSubscriptionPlanPricesResponse, | ||
>, | ||
) -> CustomResult<Vec<(String, masking::Maskable<String>)>, errors::ConnectorError> { | ||
todo!() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throw unimplemented error here instead of todo
Type of Change
Description
This PR integrates the get plan prices endpoint for chargebee, required to be called in the respective API handler for the same (not yet implemented)
Additional Changes
Motivation and Context
Closes #9054
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy