feat: Implement subscription create and record back for Chargebee #9303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ubscriptionCreate trait in subscriptions API
…nd correct import in subscriptions.rs
jagan-jaya
requested changes
Sep 9, 2025
| @@ -309,6 +326,24 @@ pub type BillingConnectorInvoiceSyncTypeV2 = dyn ConnectorIntegrationV2< | |||
| BillingConnectorInvoiceSyncResponse, | |||
| >; | |||
|
|
|||
| #[cfg(feature = "v1")] | |||
There was a problem hiding this comment.
Suggested change
| #[cfg(feature = "v1")] | |
| #[cfg(feature = "v2")] |
| RevenueRecoveryRecordBackResponse, | ||
| >; | ||
|
|
||
| #[cfg(feature = "v1")] |
There was a problem hiding this comment.
Suggested change
| #[cfg(feature = "v1")] | |
| #[cfg(feature = "v2")] |
| #[cfg(feature = "v1")] | ||
| /// Type alias for `ConnectorIntegration<SubscriptionRecordBack, SubscriptionsRecordBackRequest, RevenueRecoveryRecordBackResponse>` | ||
| pub type SubscriptionRecordBackType = dyn ConnectorIntegration< | ||
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionRecordBack, |
There was a problem hiding this comment.
Suggested change
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionRecordBack, | |
| SubscriptionRecordBack, |
| #[cfg(feature = "v1")] | ||
| /// Type alias for `ConnectorIntegration<SubscriptionCreate, SubscriptionCreateRequest, SubscriptionCreateResponse>` | ||
| pub type SubscriptionCreateType = dyn ConnectorIntegration< | ||
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionCreate, |
There was a problem hiding this comment.
Suggested change
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionCreate, | |
| SubscriptionCreate, |
| pub type SubscriptionCreateType = dyn ConnectorIntegration< | ||
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionCreate, | ||
| SubscriptionCreateRequest, | ||
| hyperswitch_domain_models::router_response_types::subscriptions::SubscriptionCreateResponse, |
There was a problem hiding this comment.
Suggested change
| hyperswitch_domain_models::router_response_types::subscriptions::SubscriptionCreateResponse, | |
| SubscriptionCreateResponse, |
| #[cfg(feature = "v1")] | ||
| /// Type alias for `ConnectorIntegrationV2<SubscriptionRecordBack, SubscriptionCreateData, SubscriptionsRecordBackRequest, RevenueRecoveryRecordBackResponse>` | ||
| pub type SubscriptionRecordBackTypeV2 = dyn ConnectorIntegrationV2< | ||
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionRecordBack, |
There was a problem hiding this comment.
Suggested change
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionRecordBack, | |
| SubscriptionRecordBack, |
Comment on lines
341
to
344
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionCreate, | ||
| flow_common_types::SubscriptionCreateData, | ||
| SubscriptionCreateRequest, | ||
| hyperswitch_domain_models::router_response_types::subscriptions::SubscriptionCreateResponse, |
There was a problem hiding this comment.
Suggested change
| hyperswitch_domain_models::router_flow_types::subscriptions::SubscriptionCreate, | |
| flow_common_types::SubscriptionCreateData, | |
| SubscriptionCreateRequest, | |
| hyperswitch_domain_models::router_response_types::subscriptions::SubscriptionCreateResponse, | |
| SubscriptionCreate, | |
| flow_common_types::SubscriptionCreateData, | |
| SubscriptionCreateRequest, | |
| SubscriptionCreateResponse, |
| { | ||
| fn get_headers( | ||
| &self, | ||
| req: &hyperswitch_domain_models::types::SubscriptionRecordBackRouterData, |
There was a problem hiding this comment.
Suggested change
| req: &hyperswitch_domain_models::types::SubscriptionRecordBackRouterData, | |
| req: &SubscriptionRecordBackRouterData, |
change it in other places also
Comment on lines
75
to
104
| Ok(Self { | ||
| item_price_id: first_item.item_price_id.clone(), | ||
| quantity: first_item.quantity, | ||
| billing_address_line1: req | ||
| .billing_address | ||
| .address | ||
| .as_ref() | ||
| .and_then(|addr| addr.line1.as_ref().map(|line1| line1.clone().expose())), | ||
| billing_address_city: req | ||
| .billing_address | ||
| .address | ||
| .as_ref() | ||
| .and_then(|addr| addr.city.clone()), | ||
| billing_address_state: req | ||
| .billing_address | ||
| .address | ||
| .as_ref() | ||
| .and_then(|addr| addr.state.as_ref().map(|state| state.clone().expose())), | ||
| billing_address_zip: req | ||
| .billing_address | ||
| .address | ||
| .as_ref() | ||
| .and_then(|addr| addr.zip.as_ref().map(|zip| zip.clone().expose())), | ||
| billing_address_country: req | ||
| .billing_address | ||
| .address | ||
| .as_ref() | ||
| .and_then(|addr| addr.country.map(|country| country.to_string())), | ||
| auto_collection: req.auto_collection.clone(), | ||
| }) |
There was a problem hiding this comment.
Suggested change
| Ok(Self { | |
| item_price_id: first_item.item_price_id.clone(), | |
| quantity: first_item.quantity, | |
| billing_address_line1: req | |
| .billing_address | |
| .address | |
| .as_ref() | |
| .and_then(|addr| addr.line1.as_ref().map(|line1| line1.clone().expose())), | |
| billing_address_city: req | |
| .billing_address | |
| .address | |
| .as_ref() | |
| .and_then(|addr| addr.city.clone()), | |
| billing_address_state: req | |
| .billing_address | |
| .address | |
| .as_ref() | |
| .and_then(|addr| addr.state.as_ref().map(|state| state.clone().expose())), | |
| billing_address_zip: req | |
| .billing_address | |
| .address | |
| .as_ref() | |
| .and_then(|addr| addr.zip.as_ref().map(|zip| zip.clone().expose())), | |
| billing_address_country: req | |
| .billing_address | |
| .address | |
| .as_ref() | |
| .and_then(|addr| addr.country.map(|country| country.to_string())), | |
| auto_collection: req.auto_collection.clone(), | |
| }) | |
| let address = req.billing_address.address.as_ref(); | |
| Ok(Self { | |
| item_price_id: first_item.item_price_id.clone(), | |
| quantity: first_item.quantity, | |
| billing_address_line1: address.and_then(|addr| addr.line1.as_ref().map(|line1| line1.clone().expose())), | |
| billing_address_city: address.and_then(|addr| addr.city.clone()), | |
| billing_address_state: address.and_then(|addr| addr.state.as_ref().map(|state| state.clone().expose())), | |
| billing_address_zip: address.and_then(|addr| addr.zip.as_ref().map(|zip| zip.clone().expose())), | |
| billing_address_country: address.and_then(|addr| addr.country.map(|country| country.to_string())), | |
| auto_collection: req.auto_collection.clone(), | |
| }) |
Comment on lines
+180
to
+184
| pub type SubscriptionRecordBackRouterData = RouterData< | ||
| SubscriptionRecordBack, | ||
| SubscriptionsRecordBackRequest, | ||
| RevenueRecoveryRecordBackResponse, | ||
| >; |
There was a problem hiding this comment.
Suggested change
| pub type SubscriptionRecordBackRouterData = RouterData< | |
| SubscriptionRecordBack, | |
| SubscriptionsRecordBackRequest, | |
| RevenueRecoveryRecordBackResponse, | |
| >; | |
| pub type SubscriptionInvoiceRecordBackRouterData = RouterData< | |
| SubscriptionInvoiceRecordBack, | |
| SubscriptionInvoiceRecordBackRequest, | |
| SubscriptionInvoiceRecordBackResponse, | |
| >; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy