Skip to content

feat(router): added retrieval flow for connector file uploads and added support for stripe connector #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2023
Merged

feat(router): added retrieval flow for connector file uploads and added support for stripe connector #990

merged 6 commits into from
May 9, 2023

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  1. added retrieval flow for connector file uploads
  2. added retrieve file flow for stripe connector

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sai-harsha-vardhan sai-harsha-vardhan added A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes R-waiting-on-L1 labels Apr 26, 2023
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Apr 26, 2023
Abhicodes-crypto
Abhicodes-crypto reviewed Apr 26, 2023
View reviewed changes
Abhicodes-crypto
Abhicodes-crypto previously approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Narayanbhat166
Narayanbhat166 previously approved these changes May 4, 2023
View reviewed changes
crates/storage_models/src/file.rs
@@ -49,6 +52,7 @@ pub struct FileMetadataUpdateInternal {
provider_file_id: Option<String>,
file_upload_provider: Option<storage_enums::FileUploadProvider>,
available: bool,
connector_label: Option<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will connector label needs to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after uploading a file to connector we need to store connector_label so that we can use it to get merchant_connector_account in file retrieval flow from connector.

Narayanbhat166
Narayanbhat166 previously approved these changes May 5, 2023
View reviewed changes
@sai-harsha-vardhan sai-harsha-vardhan added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed R-waiting-on-L2 labels May 5, 2023
jarnura
jarnura requested changes May 9, 2023
View reviewed changes
crates/router/src/core/disputes/transformers.rs Outdated
@@ -17,47 +17,54 @@ pub async fn get_evidence_request_data(
state,
evidence_request.cancellation_policy,
merchant_account,
false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the bool as a enum

@jarnura jarnura added this to the May 2023 Release milestone May 9, 2023
@jarnura jarnura added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 9, 2023
@sai-harsha-vardhan sai-harsha-vardhan added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 9, 2023
@sai-harsha-vardhan sai-harsha-vardhan requested a review from jarnura May 9, 2023 11:03
@jarnura jarnura added this pull request to the merge queue May 9, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 9, 2023
Merged via the queue into main with commit 38aa9ea May 9, 2023
@SanchithHegde SanchithHegde deleted the add_retrieval_for_connector_file_uploads branch May 9, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@vspecky vspecky Awaiting requested review from vspecky

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

+2 more reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@Abhicodes-crypto Abhicodes-crypto Abhicodes-crypto approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@sai-harsha-vardhan sai-harsha-vardhan

Labels
A-connector-integration Area: Connector integration A-core Area: Core flows C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
May 2023 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@sai-harsha-vardhan @jarnura @Narayanbhat166 @Abhicodes-crypto @SanchithHegde