Cheat sheet dark mode diagrams #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do be precise with white-space when rendering the `diagram-list` page: The main purpose of that file is to serve as input for the `script/graphviz-ssr.js` script, which wants the lines between the open and close tag to contain the precise paths, without any indentation or empty lines. Signed-off-by: Johannes Schindelin <[email protected]>
The generated SVGs now gain the `graphviz` class, which makes it easier to customize their look via CSS. This is especially important when adding support for dark mode, as there are other SVGs on the front page that should not receive the same treatment. Sadly, `node-html-parser` is not smart enough to handle `element.classList.add(...)` followed by `element.toString()` correctly: The output would _not_ have the added class. But there's always crude string processing to save the day. Signed-off-by: Johannes Schindelin <[email protected]>
CSS to the rescue! Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:-)