fix potential infinite loop by removing dynamic part of filename #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
but I guess, this variable helps to create a unique value filename on the target directory. for example, if this will create something like artifacts... It is very relevant to have. But if these configurations create such loops in exporting this file, then yet yes, it is worth re-configuring but not REMOVING.
| @@ -14,7 +14,7 @@ steps: | |||
| image: bitnami/kubectl:1.22.2 | |||
| user: root # the bitnami/kubectl image has a non-root user set by default, which does not work with the shared docker volume which is owned by root | |||
| commands: | |||
| - export KUBECONFIG=kubeconfig-$${DRONE_BUILD_STARTED}.yaml | |||
There was a problem hiding this comment.
but I guess, this variable helps to create a unique value filename on the target directory. for example, if this will create something like artifacts... It is very relevant to have. But if these configurations create such loops in exporting this file, then yet yes, it is worth re-configuring but not REMOVING.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More explanation here. #15
This is a suggested fix with a hard-coded filename. If a dynamic filename is needed, other info could be added (e.g. repo namespace and repo name, build number, or maybe just DRONE_COMMIT_SHA).