Skip to content

Conversation

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 5558747)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 6ab8b42)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 356bd5d)
Signed-off-by: Brad Davidson <[email protected]>
Requires switch from github.com/opencontainers/runc/libcontainer/cgroups -> github.com/opencontainers/cgroups

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 0254ca3)
Signed-off-by: Brad Davidson <[email protected]>
Changes to how we bootstrap the agent and apiserver address list have
made this unnecessary since 5014c9e was merged, and it is creating
problems due to only etcd-only nodes not using their own config.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 0ec4740)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit a9016f3)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit e47c497)
Signed-off-by: Brad Davidson <[email protected]>
Also cleans up some of the server.Context factory creation stuff to eliminate unused code paths and avoid registering the Helm controller when helm is disabled.

As of fe465cc we no longer call NewContext outside pkg/server, so the isServer bool flag to use the supervisor kubeconfig and create an event recorder is unnecessary.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 068a013)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 795091a)
Signed-off-by: Brad Davidson <[email protected]>
Error is deadline exceeded, not cancelled

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit f1c8239)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit d08bf6c)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit ac9f834)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 1ae5ec3)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit c837bfc)
Signed-off-by: Brad Davidson <[email protected]>
Fix apiserver-managed compact, and enable it

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit f3a036a)
Signed-off-by: Brad Davidson <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 4d1f1af)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond requested a review from a team as a code owner September 5, 2025 19:47
We no longer depend on this as a module any more, but need to keep it pinned for build-time version selection.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit a64d872)
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond force-pushed the 2024-09-backports_release-1.33 branch from 335401a to 4f82d83 Compare September 5, 2025 20:19
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 6.30631% with 104 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.15%. Comparing base (148243c) to head (4f82d83).

Files with missing lines Patch % Lines
pkg/util/logger/logger.go 0.00% 40 Missing ⚠️
pkg/server/context.go 0.00% 33 Missing ⚠️
pkg/cli/server/server.go 0.00% 8 Missing ⚠️
pkg/etcd/etcd.go 12.50% 7 Missing ⚠️
pkg/spegel/spegel.go 0.00% 6 Missing ⚠️
pkg/agent/run.go 0.00% 4 Missing ⚠️
pkg/agent/cridockerd/cridockerd.go 0.00% 3 Missing ⚠️
pkg/server/server.go 0.00% 2 Missing ⚠️
pkg/agent/config/config.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (148243c) and HEAD (4f82d83). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (148243c) HEAD (4f82d83)
unittests 6 2
e2etests 1 0
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.33   #12870       +/-   ##
=================================================
- Coverage         40.08%   20.15%   -19.94%     
=================================================
  Files               185      183        -2     
  Lines             19159    19153        -6     
=================================================
- Hits               7680     3860     -3820     
- Misses            10300    14857     +4557     
+ Partials           1179      436      -743     
Flag Coverage Δ
e2etests ?
unittests 20.15% <6.30%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant