Skip to content

Conversation

svrmnk
Copy link
Contributor

@svrmnk svrmnk commented May 15, 2024

What changes did you make? (Give an overview)

Frontend sorting for #208

I implemented sorting to the table at the Schema registry tab

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@svrmnk svrmnk requested a review from a team as a code owner May 15, 2024 10:03
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels May 15, 2024
@Mgrdich
Copy link
Contributor

Mgrdich commented May 16, 2024

@Haarolean is sorting going to be only on the frontend side ?

@Haarolean
Copy link
Member

@Haarolean is sorting going to be only on the frontend side ?

nope, the issue has the backend label which we need first to make it work with pagination

@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/frontend Related to frontend changes and removed status/triage/manual Manual triage in progress labels May 16, 2024
@Haarolean Haarolean changed the title issue 208: implement sorting to the table at the Schema registry tab FE: SR: Impl sorting May 16, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could merge this for now until we get a full backend solution

@Haarolean Haarolean removed status/pending-backend hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved labels Aug 15, 2025
@Haarolean Haarolean added this to the 1.4 milestone Aug 15, 2025
@Haarolean Haarolean linked an issue Aug 15, 2025 that may be closed by this pull request
@Haarolean Haarolean enabled auto-merge (squash) August 15, 2025 16:10
@Haarolean Haarolean merged commit 7409d4e into kafbat:main Aug 15, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 1.4 Aug 15, 2025
@Haarolean
Copy link
Member

@svrmnk thanks for your PR! Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SR: Implement sorting
3 participants