-
Notifications
You must be signed in to change notification settings - Fork 8
Create events in kcp #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ster-runtime/provider commits need them On-behalf-of: @SAP [email protected]
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
/kind feature |
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
On-behalf-of: @SAP [email protected]
Summary
This PR implements basic support for creating sync-related events on objects in kcp. Since the agent has no knowledge of any kind of operators behind it, it at the moment cannot report anything application-specific, and so all the events related to its own operation instead, like
I chose to attempt to keep the synchronization itself to be somewhat subdued. In my mind, users of kcp who make use of APIExports and stuff, should never need to know or care whether their objects are synced/copied/transfered/compressed or whatever behind the scenes to make things work. So the events the agent creates are meant to not constantly remind users that external clusters and synchronizations are involved at all. This is done on a best effort basis though.
In order to create events, the syncagent will now claim
events
in every APIExport it manages. Existing APIBindings will need to be updated to grant the agent this permission.Additionally, this PR adds
make test-e2e
to make quick testing easier.Adding event support required the latest commits of multicluster libraries, which require kube 1.33 already. However latest kcp versions (0.28.1) are on 1.32 still. We chose to break away from kcp because controller-runtime's desire for 1.33 was ultimately stronger.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #17
Release Notes