adding deeplab_v3_plus_presets #2051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
ianstenbit
suggested changes
Sep 6, 2023
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_presets.py
Outdated
Show resolved
Hide resolved
ianstenbit
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Looks good! Just a quick question about the preset bit -- @jbischof curious about your take as well. (IMO we should make this from_preset change on the Task class instead of just for DeepLabV3Plus
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus.py
Outdated
Show resolved
Hide resolved
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_test.py
Outdated
Show resolved
Hide resolved
ianstenbit
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
LGTM -- @jbischof PTAL quickly to verify that you're cool with this change to from_preset
|
/gcbrun |
ianstenbit
reviewed
Sep 18, 2023
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_test.py
Outdated
Show resolved
Hide resolved
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
jbischof
reviewed
Sep 19, 2023
ianstenbit
reviewed
Sep 19, 2023
keras_cv/models/segmentation/deeplab_v3_plus/deeplab_v3_plus_test.py
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
|
@divyashreepathihalli |
|
/gcbrun |
|
/gcbrun |
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
* adding deeplab_v3_plus_presets * update formatting * fixed error * reformatted * fix errors * added num_classses arg * add input_shape arg * update test * update input_shape * updated preset * update test * move update to from_preset to task.py * reformatted code * updated doc string * Update assert * Update deeplab_v3_plus_test.py test * Update task.py * Update deeplab_v3_plus_test.py * Update deeplab_v3_plus_test.py
yuvraj-wale
pushed a commit
to yuvraj-wale/keras-cv
that referenced
this pull request
Feb 8, 2024
* adding deeplab_v3_plus_presets * update formatting * fixed error * reformatted * fix errors * added num_classses arg * add input_shape arg * update test * update input_shape * updated preset * update test * move update to from_preset to task.py * reformatted code * updated doc string * Update assert * Update deeplab_v3_plus_test.py test * Update task.py * Update deeplab_v3_plus_test.py * Update deeplab_v3_plus_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.