Python Middleware v2 Scaffolding #2685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
kind/enhancement
do-not-merge/work-in-progress
knative-prow
bot
added
the
approved
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
added
the
size/XXL
matzew
reviewed
Feb 7, 2025
|
nice for getting this started |
lkingland
force-pushed
the
scaffolding-python
branch
from
ec91040 to
182c74c
Compare
Inbuilt templates should be limited to a base http and cloudevent integration, with anything beyond this falling to the officially supported functions samples repository.
lkingland
force-pushed
the
scaffolding-python
branch
from
b813d8c to
269a8b2
Compare
lkingland
force-pushed
the
scaffolding-python
branch
3 times, most recently
from
7488267 to
a51bd6a
Compare
lkingland
force-pushed
the
scaffolding-python
branch
from
a51bd6a to
9ecb85c
Compare
matzew
reviewed
Mar 27, 2025
knative-prow-robot
added
the
needs-rebase
matzew
reviewed
Mar 27, 2025
|
ON, https://github.com/lkingland/func/tree/scaffolding-python/templates/python |
matejvasek
reviewed
Mar 27, 2025
knative-prow-robot
removed
the
needs-rebase
lkingland
force-pushed
the
scaffolding-python
branch
from
3ae0f09 to
727d1dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
- Coverage 62.61% 62.48% -0.13%
==========================================
Files 131 131
Lines 15588 15921 +333
==========================================
+ Hits 9761 9949 +188
- Misses 4902 5017 +115
- Partials 925 955 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gauron99
approved these changes
Apr 2, 2025
| Once Functions is stable and post 1.0, it would be worth exploring adding | ||
| Functions support in the upstream base scripts themselves via environment | ||
| variable. | ||
| */ |
There was a problem hiding this comment.
love the top-of-file overview comment ❤️
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
reviewed
Apr 2, 2025
| @@ -45,20 +63,23 @@ func buildGoLayer(cfg *buildConfig, p v1.Platform) (desc v1.Descriptor, layer v1 | |||
| desc.Platform = &p | |||
|
|
|||
| // Blob | |||
| blob := path(cfg.blobsDir(), desc.Digest.Hex) | |||
| blob := filepath.Join(cfg.blobsDir(), desc.Digest.Hex) | |||
| if cfg.verbose { | |||
| fmt.Printf("mv %v %v\n", rel(cfg.buildDir(), target), rel(cfg.buildDir(), blob)) | |||
| } | |||
| err = os.Rename(target, blob) | |||
There was a problem hiding this comment.
@lkingland you are ignoring the err here.
matejvasek
added a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 3, 2025
Signed-off-by: Matej Vašek <[email protected]>
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Apr 4, 2025
* Pick knative#2685 Signed-off-by: Matej Vašek <[email protected]> * Fix Python S2I On-Cluster build Signed-off-by: Matej Vašek <[email protected]> --------- Signed-off-by: Matej Vašek <[email protected]> Signed-off-by: Matej Vašek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
🎁 Host builder now supports Python Functions
🎁 Can now
func runPython Functions locally outside of a container (no container runtime required)🎁 Python Functions now suppport instanced method signatures
🎁 Python Functions now support lifecycle events (start, stop, readiness, liveness)
🎁 Updates Python Template Tests to use pytest
🎁 Python Functions now use the ASGI Spec and run using an ASGI optimized server
🎁 adds support for base images to the OCI builder
🧹 Cleans up .gitignore
🧹 Cleans up and simplifies the OCI builder
🧹 Cleans up and simplifies the repository management code
🧹 removes broken interactive prompts from the
runcommand pending forthcoming UX update/kind enhancement
Fixes #
Release Note
Docs