Skip to content

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Aug 28, 2025

  • This is a hotfix for the remote python pack deployment.
  • Implements the "python injector" workaround for remote as well.
  • Please note that this is bound to change! with a larger scale re-do of the scaffolding implementation (the injector wont be needed at all)

fixes #2985

Copy link

knative-prow bot commented Aug 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2025
Copy link

knative-prow bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from jrangelramos and nainaz August 28, 2025 06:09
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 28, 2025
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 33.64486% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.82%. Comparing base (fa769ca) to head (ce4e875).

Files with missing lines Patch % Lines
pkg/pipelines/tekton/pipelines_provider.go 6.57% 69 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3004      +/-   ##
==========================================
+ Coverage   58.72%   58.82%   +0.10%     
==========================================
  Files         132      132              
  Lines       16955    17041      +86     
==========================================
+ Hits         9957    10025      +68     
+ Misses       6069     6055      -14     
- Partials      929      961      +32     
Flag Coverage Δ
e2e-tests 33.16% <0.00%> (-6.45%) ⬇️
integration-tests 54.06% <33.64%> (+1.46%) ⬆️
unit-tests 46.29% <33.64%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-loznlwuozlqs branch 2 times, most recently from 230eec5 to 389cd19 Compare August 28, 2025 09:59
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 29, 2025

This does fix the immediate issue of direct upload remote deployment ( deploy local code to cluster ) with python + pack but the "hacky" changes do fail the non-direct upload (using the git deployment) therefore instead of digging further into this temporary hack - Im going to start the subsequent work immediately of the scaffolding rework, which will include the python + pack fix.

If you are reading this coming from the issue linked, please feel free to pull this PR branch and use the python+pack remote deployment when using local code in the meantime! Thank you for understanding.

closes issue to track is #3005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Func deploy python not work.
1 participant