-
Notifications
You must be signed in to change notification settings - Fork 157
fix: hotfix remote python with pack builder deploy #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
+ Coverage 58.72% 58.82% +0.10%
==========================================
Files 132 132
Lines 16955 17041 +86
==========================================
+ Hits 9957 10025 +68
+ Misses 6069 6055 -14
- Partials 929 961 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
230eec5
to
389cd19
Compare
389cd19
to
ce4e875
Compare
This does fix the immediate issue of direct upload remote deployment ( deploy local code to cluster ) with python + pack but the "hacky" changes do fail the non-direct upload (using the git deployment) therefore instead of digging further into this temporary hack - Im going to start the subsequent work immediately of the scaffolding rework, which will include the python + pack fix. If you are reading this coming from the issue linked, please feel free to pull this PR branch and use the python+pack remote deployment when using local code in the meantime! Thank you for understanding. closes issue to track is #3005 |
fixes #2985