Skip to content

Conversation

connorlindsey
Copy link
Contributor

Adds a tool to list, get, upsert, send, and cancel broadcasts. Dependent on merging and releasing the related MAPI changes.

Copy link

linear bot commented Jul 21, 2025

Copy link

changeset-bot bot commented Jul 21, 2025

🦋 Changeset detected

Latest commit: 7a7b66a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@knocklabs/agent-toolkit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@connorlindsey connorlindsey marked this pull request as ready for review July 22, 2025 16:28
"(string): The key of the audience to target for this broadcast."
),
steps: z
.array(z.record(z.any()))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can’t do an array of any here - it will cause issues with certain models. We need to specify the types.

it would be nice to have a way here to share the types from the workflow to manage this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, I'll update the type

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow tool doesn't type steps at all since we're using the workflow steps tool. Do you think broadcasts should do something similar having a tool per channel / step type or should I just pull out and share the types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants