Skip to content

Update the cluster templates with the latest changes added in cluster-api version 1.11.0-alpha.2 #2414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2025
Merged

Update the cluster templates with the latest changes added in cluster-api version 1.11.0-alpha.2 #2414

merged 1 commit into from
Jul 7, 2025

Conversation

Amulyam24
Copy link
Contributor

@Amulyam24 Amulyam24 commented Jul 3, 2025 •
edited
Loading

What this PR does / why we need it:
Update the cluster templates with the latest changes added in cluster-api version 1.11.0-alpha.2

errors on template deployment

Error from server (BadRequest): error when creating "first.yaml": Cluster in version "v1beta2" cannot be handled as a Cluster: strict decoding error: unknown field "spec.controlPlaneRef.apiVersion", unknown field "spec.infrastructureRef.apiVersion"
Error from server (BadRequest): error when creating "first.yaml": KubeadmControlPlane in version "v1beta2" cannot be handled as a KubeadmControlPlane: strict decoding error: unknown field "spec.machineTemplate.infrastructureRef.apiVersion"
Error from server (BadRequest): error when creating "first.yaml": MachineDeployment in version "v1beta2" cannot be handled as a MachineDeployment: strict decoding error: unknown field "spec.template.spec.bootstrap.configRef.apiVersion", unknown field "spec.template.spec.infrastructureRef.apiVersion"
Error from server (Invalid): error when creating "first.yaml": KubeadmConfigTemplate.bootstrap.cluster.x-k8s.io "ibm-powervs-1-md-0" is invalid: spec.template.spec.joinConfiguration.discovery.bootstrapToken.token: Invalid value: "": spec.template.spec.joinConfiguration.discovery.bootstrapToken.token in body should be at least 1 chars long

Error from server (BadRequest): error when creating "vpc-cc.yaml": Cluster in version "v1beta2" cannot be handled as a Cluster: strict decoding error: unknown field "spec.topology.class"
Error from server (BadRequest): error when creating "vpc-cc.yaml": ClusterClass in version "v1beta2" cannot be handled as a ClusterClass: strict decoding error: unknown field "spec.controlPlane.machineInfrastructure.ref.namespace", unknown field "spec.controlPlane.ref.namespace", unknown field "spec.infrastructure.ref.namespace"
Error from server (BadRequest): error when creating "vpc-cc.yaml": KubeadmControlPlaneTemplate in version "v1beta2" cannot be handled as a KubeadmControlPlaneTemplate: strict decoding error: unknown field "spec.template.spec.kubeadmConfigSpec.clusterConfiguration.kubernetesVersion"

PR which introduced most of the changes - kubernetes-sigs/cluster-api#12356
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update the cluster templates with the latest changes added in cluster-api version 1.11.0-alpha.2

@k8s-ci-robot k8s-ci-robot added area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 3, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit 28f6db3
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/6867945afcf6540008aa2fb0
😎 Deploy Preview https://deploy-preview-2414.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 3, 2025
@Amulyam24
Copy link
Contributor Author

/hold for VPC cluster testing

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2025
@Amulyam24
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@Amulyam24
Copy link
Contributor Author

PR is ready for review

@Amulyam24
Copy link
Contributor Author

/cc @Prajyot-Parab

Karthik-K-N
Karthik-K-N reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

but would you mind mentioning the respective CAPI PR's which made these changes, like changing from apiVersion to apiGroup

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2025
@Amulyam24
Copy link
Contributor Author

but would you mind mentioning the respective CAPI PR's which made these changes, like changing from apiVersion to apiGroup

Sure, updated the description.

Amulyam24
Amulyam24 commented Jul 7, 2025
View reviewed changes
templates/cluster-template-powervs.yaml
@@ -187,7 +187,6 @@ spec:
bootstrapToken:
apiServerEndpoint: ${IBMPOWERVS_VIP}:${API_SERVER_PORT:=6443}
caCertHashes: []
token: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error:
The KubeadmControlPlane "ibm-powervs-1-control-plane" is invalid: spec.kubeadmConfigSpec.joinConfiguration.discovery.bootstrapToken.token: Invalid value: "": spec.kubeadmConfigSpec.joinConfiguration.discovery.bootstrapToken.token in body should be at least 1 chars long

Prajyot-Parab
Prajyot-Parab approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@Prajyot-Parab Prajyot-Parab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit add6d1c into kubernetes-sigs:main Jul 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prajyot-Parab Prajyot-Parab Prajyot-Parab approved these changes

@mkumatag mkumatag Awaiting requested review from mkumatag

+1 more reviewer

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Karthik-K-N Karthik-K-N

@Prajyot-Parab Prajyot-Parab

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Amulyam24 @k8s-ci-robot @Karthik-K-N @Prajyot-Parab