Skip to content

Conversation

EmilienM
Copy link
Contributor

What this PR does / why we need it:

Specifying the patch version is not needed and can causes problems on systems which haven't updated yet to the 1.23.4.

Specifying the patch version is not needed and can causes problems on
systems which haven't updated yet to the 1.23.4.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 12, 2025
Copy link

netlify bot commented Feb 12, 2025

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 97ce2bc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/67acd17525957e0008d04e04
😎 Deploy Preview https://deploy-preview-2424--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdbooth
Copy link
Contributor

mdbooth commented Feb 12, 2025

/lgtm

I wonder if we can document this somewhere. Perhaps a comment in go.mod not to specify a patch version other than .0 unless we've positively determined that it's required?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@EmilienM
Copy link
Contributor Author

I think it is a best practice to let .0 so we don't need to document that for now.
This was clearly a mistake when I did this though.
I think we're good to go
/approve
/cherry-pick release-0.12

@k8s-infra-cherrypick-robot

@EmilienM: once the present PR merges, I will cherry-pick it on top of release-0.12 in a new PR and assign it to you.

In response to this:

I think it is a best practice to let .0 so we don't need to document that for now.
This was clearly a mistake when I did this though.
I think we're good to go
/approve
/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit d850aa6 into kubernetes-sigs:main Feb 12, 2025
9 checks passed
@k8s-infra-cherrypick-robot

@EmilienM: new pull request created: #2425

In response to this:

I think it is a best practice to let .0 so we don't need to document that for now.
This was clearly a mistake when I did this though.
I think we're good to go
/approve
/cherry-pick release-0.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants