Skip to content

Conversation

nerdeveloper
Copy link
Contributor

  • Add Status Conditions support following K8s API conventions
  • Implement meta.SetStatusCondition() throughout reconciliation
  • Add condition types: Available, Progressing, Degraded
  • Update tests to verify Status Conditions behavior
  • Add test cases for suspended CronJobs

This aligns the tutorials with best practices demonstrated in the Deploy Image Plugin example, addressing issue #5024 and #4019.

Note: This PR contains manual changes to the tutorial code. The CI will fail as make generate needs updates (will be handled in a follow-up PR per the proposed solution).

- Add Status Conditions support following K8s API conventions
- Implement meta.SetStatusCondition() throughout reconciliation
- Add condition types: Available, Progressing, Degraded
- Update tests to verify Status Conditions behavior
- Add test cases for suspended CronJobs

This aligns the tutorials with best practices demonstrated in the
Deploy Image Plugin example, addressing issue kubernetes-sigs#5024 and kubernetes-sigs#4019.

Note: This PR contains manual changes to the tutorial code. The CI
will fail as make generate needs updates (will be handled in a
follow-up PR per the proposed solution).
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nerdeveloper
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @nerdeveloper. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants