Move from bit.ly URLs to rel.k8s.io for the release team #8109
Conversation
k8s-ci-robot
requested review from
BenTheElder,
fsmunoz,
katcosgrove and
neoaggelos
k8s-ci-robot
added
cncf-cla: yes
|
/cc @xmudrii |
Vyom-Yadav
force-pushed
the
replace-rt-bitly-links
branch
from
8cade56 to
2ddb574
Compare
apps/k8s-io/configmap-nginx.yaml
Outdated
| if ($major = "1" && $minor <= "33") { | ||
| return 301 https://bit.ly/k8s$major$minor-$remaining; | ||
| } |
There was a problem hiding this comment.
Thinking about this again, this could allow for something similar to subdomain takeover or unknown redirect.
rel.k8s.io/v123/steal-your-passwords would redirect externally to https://bit.ly/k8s123-steal-your-passwords which isn't safe imo. (As the user would trust rel.k8s.io)
For maintaining backwards compatibility, we can have a generic links.md in sig-release which would have the generic URLs for previous release.
There was a problem hiding this comment.
We should also constrain the lower bound if we go this route.
EDIT: To whatever version we know has all these links already to avoid squatting
I think it might be best to directly include them here without the bit.ly link in the middle?
There was a problem hiding this comment.
Yeah, having bit ly remains doesn't seem like a great solution. I can write a short script which can auto populate links.md for the older releases.
Updated this to do a redirect to sig-release only.
Signed-off-by: Vyom Yadav <[email protected]>
Vyom-Yadav
force-pushed
the
replace-rt-bitly-links
branch
from
2ddb574 to
cd89e89
Compare
|
ping @BenTheElder I addressed the review comment above. |
|
@Vyom-Yadav sent me a nudge in slack, sorry I let this fall off my radar. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, Vyom-Yadav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I think this still has to be manually deployed. |
Bit ly has started adding ads between redirects, so we're moving away from bit ly.
Context: https://kubernetes.slack.com/archives/C2C40FMNF/p1739462854147559
/cc @BenTheElder @katcosgrove @fsmunoz @neoaggelos