Skip to content

Terraform for k8s-s390x-conformance job on ibmcloud #8414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Terraform for k8s-s390x-conformance job on ibmcloud #8414

wants to merge 1 commit into from

Conversation

sudharshanibm
Copy link
Contributor

Terraform for k8s-s390x-conformance job on ibmcloud

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @sudharshanibm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sudharshanibm
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/infra Infrastructure management, infrastructure design, code in infra/ label Aug 18, 2025
@k8s-ci-robot k8s-ci-robot added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Aug 18, 2025
@sudharshanibm sudharshanibm force-pushed the k8s-s390x-conformance branch from 776f886 to 663f502 Compare August 18, 2025 12:45
@brahads brahads mentioned this pull request Aug 18, 2025
Open
18 tasks
@sudharshanibm sudharshanibm force-pushed the k8s-s390x-conformance branch 2 times, most recently from 46278a3 to 1f9ed13 Compare August 19, 2025 07:18
@sudharshanibm sudharshanibm force-pushed the k8s-s390x-conformance branch 2 times, most recently from 8918c1e to 61eddcb Compare September 1, 2025 05:21
bryantbiggs
bryantbiggs reviewed Sep 13, 2025
View reviewed changes
infra/ibmcloud/terraform/k8s-s390x-conformance/modules/resource_group/resource_group.tf
See the License for the specific language governing permissions and
limitations under the License.
*/
resource "ibm_resource_group" "conformance_resource_group" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single resource module not good - just use the resource, no module required

bryantbiggs
bryantbiggs reviewed Sep 13, 2025
View reviewed changes
infra/ibmcloud/terraform/k8s-s390x-conformance/modules/secrets_manager/secret_manager.tf
@@ -0,0 +1,92 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like theres overlap with #8413 - we should start with one PR and land that first and then iterate/add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@xmudrii xmudrii Awaiting requested review from xmudrii

1 more reviewer

@bryantbiggs bryantbiggs bryantbiggs left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudharshanibm @k8s-ci-robot @bryantbiggs