Skip to content

add group for karpenter clusterapi #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

add group for karpenter clusterapi #8495

merged 1 commit into from
Sep 17, 2025
+11 −0

Conversation

elmiko
Copy link
Contributor

@elmiko elmiko commented Sep 11, 2025

This change adds a google group for access control for the karpenter provider cluster api project. It adds the cluster lifecycle leads as additional members in the group.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 11, 2025
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 11, 2025

cc @ameukam

This was referenced Sep 11, 2025
Closed
Open
neolit123
neolit123 reviewed Sep 11, 2025
View reviewed changes
@elmiko elmiko force-pushed the add-karp-capi-group branch from ac1cd29 to dc0fa4a Compare September 17, 2025 16:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 17, 2025
@elmiko
Copy link
Contributor Author

elmiko commented Sep 17, 2025

not sure why it's showing all those comment lines removed. did i miss a rebase or something?

neolit123
neolit123 reviewed Sep 17, 2025
View reviewed changes
groups/sig-cluster-lifecycle/groups.yaml
- [email protected]
- [email protected]

#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments are part of the file.
https://github.com/kubernetes/k8s.io/blob/main/groups/sig-cluster-lifecycle/groups.yaml#L504

try adding the new groups on top of these comments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, think i got it fixed =)

@elmiko
add group for karpenter clusterapi
0f0a6ac 
This change adds a google group for access control for the karpenter provider
cluster api project. It adds the cluster lifecycle leads as additional members
in the group.
@elmiko elmiko force-pushed the add-karp-capi-group branch from dc0fa4a to 0f0a6ac Compare September 17, 2025 20:19
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2025
neolit123
neolit123 reviewed Sep 17, 2025
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 17, 2025
@neolit123
Copy link
Member

need a groups/OWNERS approval too.

@ameukam
Copy link
Member

ameukam commented Sep 17, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, elmiko, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit a536f1b into kubernetes:main Sep 17, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

1 more reviewer

@neolit123 neolit123 neolit123 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
4 participants
@elmiko @neolit123 @ameukam @k8s-ci-robot