Skip to content

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Jan 14, 2025

What this PR does / why we need it:

Add the sig-compute-virtctl subproject to sigs.yaml.

See kubevirt/kubevirt#13677

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Jan 14, 2025
@0xFelix
Copy link
Member Author

0xFelix commented Jan 14, 2025

Need to wait for kubevirt/kubevirt#13677 to be merged first

@dhiller
Copy link
Contributor

dhiller commented Jan 14, 2025

@0xFelix: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-community-make-generate fc123ae link true /test pull-community-make-generate

@0xFelix it seems that the OWNERS file does not exist (yet) - I figure the PR that adds this is not yet merged?

@0xFelix
Copy link
Member Author

0xFelix commented Jan 14, 2025

@dhiller Yes, see comment above.

@0xFelix
Copy link
Member Author

0xFelix commented Jan 14, 2025

/retest

kubevirt/kubevirt#13677 was merged.

@0xFelix
Copy link
Member Author

0xFelix commented Jan 15, 2025

@dhiller Should be good to merge now.

Copy link
Member

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
@vladikr
Copy link
Member

vladikr commented Jan 16, 2025

Thanks @0xFelix
/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@kubevirt-bot kubevirt-bot merged commit 6aca72a into kubevirt:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants