[13.x] Remove function existence checks #54876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why are the tests failing? |
|
failures appear to be unrelated to your changes. sometimes this happens. I'd move the PR out of draft, and let the Laravel team re-trigger the CI suite. |
AndrewMast
reviewed
Mar 4, 2025
| } | ||
|
|
||
| return true; | ||
| return json_validate($value, 512); |
There was a problem hiding this comment.
Can't we remove the 512 here? That's the default and we don't include it in the changes in ValidatesAttributes.php in this PR.
There was a problem hiding this comment.
I'd agree. I imagine a PR for this would get accepted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Laravel 13 requires PHP 8.3, these methods are always available. This commit removes redundant function_exists() checks and simplifies the affected methods accordingly.