Skip to content

[13.x] Add #[\Override] to the BatchFake class methods #55358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

[13.x] Add #[\Override] to the BatchFake class methods #55358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Illuminate/Support/Testing/Fakes/BatchFake.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ public function __construct(
*
* @return self
*/
#[\Override]
public function fresh()
{
return $this;
Expand All @@ -78,6 +79,7 @@ public function fresh()
* @param \Illuminate\Support\Enumerable|object|array $jobs
* @return self
*/
#[\Override]
public function add($jobs)
{
$jobs = Collection::wrap($jobs);
Expand All @@ -97,6 +99,7 @@ public function add($jobs)
* @param string $jobId
* @return void
*/
#[\Override]
public function recordSuccessfulJob(string $jobId)
{
//
Expand All @@ -108,6 +111,7 @@ public function recordSuccessfulJob(string $jobId)
* @param string $jobId
* @return void
*/
#[\Override]
public function decrementPendingJobs(string $jobId)
{
//
Expand All @@ -120,6 +124,7 @@ public function decrementPendingJobs(string $jobId)
* @param \Throwable $e
* @return void
*/
#[\Override]
public function recordFailedJob(string $jobId, $e)
{
//
Expand All @@ -131,6 +136,7 @@ public function recordFailedJob(string $jobId, $e)
* @param string $jobId
* @return \Illuminate\Bus\UpdatedBatchJobCounts
*/
#[\Override]
public function incrementFailedJobs(string $jobId)
{
return new UpdatedBatchJobCounts;
Expand All @@ -141,6 +147,7 @@ public function incrementFailedJobs(string $jobId)
*
* @return void
*/
#[\Override]
public function cancel()
{
$this->cancelledAt = Carbon::now();
Expand All @@ -151,6 +158,7 @@ public function cancel()
*
* @return void
*/
#[\Override]
public function delete()
{
$this->deleted = true;
Expand Down
Loading